fix:add indexdb storage by elribonazo · Pull Request #1339 · MetaMask/metamask-sdk

elribonazo · 2025-07-30T11:42:13Z

Explanation

Add simple storage wrapper using indexeddb for web platforms and dapps.
This same new storage will be used for dappClient and mwp.

Also improved the way we are mocking each environment now we don't need to duplicate the code but call a runTestInPlatform function and the rest is done for you, this loads global variables for nodejs, web and react-native platforms and enables us to test real scenarios without directly doing any native work

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

codecov · 2025-07-30T12:07:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.93%. Comparing base (26005b4) to head (57ee31c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-07-30T13:20:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jiexi · 2025-09-18T16:13:16Z

+			},
+		} as any;
+		return __storage;
+	});


i'm a little confused. Why do we need fake-indexeddb/auto if we're just mocking the adapter that wraps it?

thats true, fake-indexeddb/auto is no longer needed. This mock came after

sonarqubecloud · 2025-09-19T10:37:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

elribonazo requested a review from a team as a code owner July 30, 2025 11:42